Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing check for error when forgetting after a backup #240

Closed
rdelaage opened this issue Sep 25, 2022 · 0 comments · Fixed by #241
Closed

Missing check for error when forgetting after a backup #240

rdelaage opened this issue Sep 25, 2022 · 0 comments · Fixed by #241

Comments

@rdelaage
Copy link
Contributor

Describe the bug
When there is an error during forgetting snapshots after a backup, the error is not reported. So errors are not reported and failure hooks are not executed

Expected behavior
The backup function should catch the error returned by forget function.

Environment

  • OS: Linux/Debian

Additional context
https://github.com/cupcakearmy/autorestic/blob/master/internal/location.go#L311
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check for errors on forget after having backuped rdelaage/autorestic
1 participant
@rdelaage