Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

long vignettes and tests #37

Open
topepo opened this issue Mar 27, 2021 · 0 comments
Open

long vignettes and tests #37

topepo opened this issue Mar 27, 2021 · 0 comments

Comments

@topepo
Copy link
Collaborator

topepo commented Mar 27, 2021

Some of the vignettes and tests take a really long time and rely on packages not in the description file.

I propose that:

  • Move the vignettes to a sub-directory in vignettes
  • Update the _pkgdown.yml so that these get build by GHA when the pkgdown site is updated.
  • Temporarily park the tests using rsample and tune in a branch.
  • Once we get closer to a release, move those tests to the extratests package (where we do cross-package system tests).

For the vignettes, they wouldn't be listed on the CRAN page but are shown on the pkgdown site. We could get them on the CRAN page if we made a page with a simple redirect. We do this for some longer running vignettes (like in workflowsets).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant