Skip to content

Allow "clone", "pour" etc to operate on other scopes #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AndreasArvidsson opened this issue Aug 17, 2021 · 3 comments · Fixed by #672
Closed

Allow "clone", "pour" etc to operate on other scopes #242

AndreasArvidsson opened this issue Aug 17, 2021 · 3 comments · Fixed by #672
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@AndreasArvidsson
Copy link
Member

AndreasArvidsson commented Aug 17, 2021

For example "pour air" would make a new line, "pour token air" would insert space and leave cursor on same line, "pour arg air" would insert comma and leave cursor after. Similarly, "clone air" would clone the line, but "clone token air", "clone arg air" etc would operate with the corresponding delimiters

Using action preference selection type

Springs from #230

Will rely on #202

Should we also handle "drop" / "float" / "puff" the same way? So eg "float argue air" would insert a , before the argument

@pokey
Copy link
Member

pokey commented May 26, 2022

@AndreasArvidsson So I think the only thing missing from #672 here is "float", "drop" and "puff". Not saying we should impl those in that PR—it's already massive. But maybe we should file those into a follow-up issue?

@AndreasArvidsson
Copy link
Member Author

Personally I'm not sure that they actually are that useful. If you would like them I would file a follow up issue because the meat of the first issues already done.

@pokey
Copy link
Member

pokey commented May 26, 2022

Yeah that's fine; tbh I'm on the fence about them too. Let's see if we find ourselves wanting them in actual usage

@pokey pokey closed this as completed in #672 Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants