Skip to content

Support full document iteration scope for all languages #2883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
AndreasArvidsson opened this issue Apr 12, 2025 · 0 comments · May be fixed by #2902
Open

Support full document iteration scope for all languages #2883

AndreasArvidsson opened this issue Apr 12, 2025 · 0 comments · May be fixed by #2902
Assignees
@AndreasArvidsson

Comments

@AndreasArvidsson
Copy link
Member

For multiple languages the root node in the parse tree is not the full document. Empty leading and trailing lines are omitted. Because of that "take all <scope>" can fail in the document root.

  • Add new predicate that utilizes the entire document range
  • Go through all *.iteration.document.scope files and make sure they include a leading empty line to capture this behavior.
@AndreasArvidsson AndreasArvidsson self-assigned this Apr 22, 2025
@AndreasArvidsson AndreasArvidsson linked a pull request Apr 22, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndreasArvidsson AndreasArvidsson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added document range predicate cursorless-dev/cursorless
1 participant
@AndreasArvidsson