Skip to content

Have syntactic sugar for "bring to before", "bring to after", etc #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pokey opened this issue Jul 13, 2021 · 1 comment
Closed

Have syntactic sugar for "bring to before", "bring to after", etc #464

pokey opened this issue Jul 13, 2021 · 1 comment
Assignees
Labels
enhancement New feature or request talon Related to cursorless-talon
Milestone

Comments

@pokey
Copy link
Member

pokey commented Jul 13, 2021

We'd like to be able to say "bring air before bat", "move air after bat", etc, rather than "bring air to before bat", "move air to after bat", etc.

I wonder if we also want to support "move after bat" as shorthand for "move this to after bat". Note that this behaviour won't come for free with the above change, because saying "move after bat" is actually supported today, but it doesn't do what you might expect: it will take the empty range after the "bat" token and insert it at the current position. So I believe it will be equivalent to "chuck this"! Haven't test that hypothesis tho 😊

We might consider being stricter about where user can use positional modifiers like "after" and "before", because you can / will be able to recover their functionality more naturally in other ways, so maybe they should just be allowed in specific places. For example

  • "take air past before bat" => "take air till bat"
  • "move air to before bat" => "move air before bat"
  • "take before bat" => "pre bat"
  • "take line before bat" will use the special construct "<SCOPE_TYPE> before"
  • "move this before bat" => "move before bat"

Not sure bout the last paragraph; just a thought. Could be useful to have fully compositional positional modifiers

@pokey pokey transferred this issue from cursorless-dev/cursorless-talon Jan 12, 2022
@pokey pokey added enhancement New feature or request talon Related to cursorless-talon labels Jan 12, 2022
@pokey pokey added this to the On deck milestone Jan 18, 2022
@pokey pokey self-assigned this Jan 18, 2022
@pokey
Copy link
Member Author

pokey commented Jun 8, 2022

Fixed by #672

@pokey pokey closed this as completed Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request talon Related to cursorless-talon
Projects
None yet
Development

No branches or pull requests

1 participant