Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Card takes up space in a vertical stack card even when all content is hidden #58

Open
2 tasks done
ScottG489 opened this issue Jan 4, 2023 · 0 comments
Open
2 tasks done
Labels
bug Something isn't working

Comments

@ScottG489
Copy link

Checklist:

  • I updated to the latest version available
  • I cleared the cache of my browser

Release with the issue:
0.6.3

Browser and Operating System:
N/A (issue replicates on Google TV in Kiosk browser, Google Chrome on Ubuntu, Google Chrome on Mac, etc)

Description of problem:
The decluttering card still takes up space even when all its contents are hidden. Since this is a wrapper card I can see how it would be difficult to know when all it's content is hidden, though.

It isn't completely the fault of this card as it seems like it does try to detect this and hide itself. However, some cards don't hide themselves properly and I think we could try to be more robust in how we hide ourselves.

Additional information:
The only idea I have here is in addition to how we check if child cards are hidden, we could also hide ourselves if the size they are taking up is 0? You can see here that the offending card (that should be applying display: none but doesnt) has no dimensions:
Screen Shot 2023-01-04 at 1 16 48 PM
but the decluttering-card still does since we don't apply display: none:
Screen Shot 2023-01-04 at 1 18 11 PM

@ScottG489 ScottG489 added the bug Something isn't working label Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant