Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move communication to BLE devices to pypi package #14

Closed
1 task done
Ernst79 opened this issue Dec 11, 2019 · 4 comments
Closed
1 task done

Move communication to BLE devices to pypi package #14

Ernst79 opened this issue Dec 11, 2019 · 4 comments

Comments

@Ernst79
Copy link
Collaborator

Ernst79 commented Dec 11, 2019

This custom component will (hopefully) result in an official integration in Home Assistant. First, a couple of bugs need to be fixed, which will take some time.

When that is finished, the next step would be to create a pypi package that handles the communication part of the code. The official home assistant developers documentation states the following:

All communication to external devices or services must be wrapped in an external Python library hosted on pypi.

This issue is created to collect the information we need, and to discuss the development for this.

Note however that @Magalex2x14 is first focusing on bug fixing the current code.

Progress

@Ernst79
Copy link
Collaborator Author

Ernst79 commented Dec 11, 2019

@Magalex2x14 This issue is not aimed to push you. I just created this issue for myself, so I can start looking into this, collect information and prepare some stuff. Even if it takes months before all bugs are sorted out, I can already start looking into this what we need in the end. I guess, in the end, we can just move part of your code out of sensor.py to the pypi package.

@Magalex2x14
Copy link
Collaborator

This issue intersects with #9 . It is quite possible that the matter will be solved with the help of existing libraries using the BlueZ D-Bus API.

@Ernst79
Copy link
Collaborator Author

Ernst79 commented Dec 11, 2019

Ok, it’s not quite clear to me when one should move things to an pypi package and when not. Let’s see after you’ve implemented #9 if this issue is still relevant. Found an example here, maybe helpful for you. https://git.kernel.org/pub/scm/bluetooth/bluez.git/tree/test/example-gatt-client

@Ernst79
Copy link
Collaborator Author

Ernst79 commented Jan 1, 2020

Closing this issue for now. We can always reopen it if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants