Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Header and Footer #19

Open
Light-Wizzard opened this issue Oct 1, 2018 · 0 comments
Open

Feature request: Header and Footer #19

Light-Wizzard opened this issue Oct 1, 2018 · 0 comments

Comments

@Light-Wizzard
Copy link
Contributor

Currently you would have to edit the Templates to add a Header and Footer; plus connect the database fields for Site Title and Tagline; and there is no Footer database field; so that would have to hard coded.

There are two ways I can think of to do this; one is to just duplicate the Code Injector and call it the HTML Injector; the other is to use Bootstrap and complete the code in the Templates; adding another field for the Footer.

The Code Injector allows you to inject Code into the Header and Footer; this HTML Injector injects HTML; so you can reuse the code for the injector; and just change where you inject the code into the Body instead of the Header; otherwise it seems to me we can just reuse this code by copy and rename, and a few changes; so its an easy feature to add as far as work goes.

This is a must have feature; it allows the user to set their Site Title and Tagline names; so if you make it flexible and allow them to edit the code; you should insert a default record with the correct Code; this is where Bootstrap comes in; I know it has features to do just this; so you could just hard code this into the code; or make it a database record you can edit; either way it needs to accomplish the same thing out of the box. Grant you that in the back end you would have an HTML code block to update; not nice; and why its best just to hard code the Header Site Title and Tagline; even add a field called footer; that is just like the tagline; extra info you want to display on all pages.

The Easy way to do this is to just Hard Code it and add the HTML Injector; and its also very Flexible; so you have to determine what is best; its not easy to maintain HTML code in a Database even with a WYSIWYG editor.

I can write the code if you are busy; and do a pull request; but I need guild lines for how you would like to have this feature work; I do not want to waist your time looking at code; if you do not like the concept of how its implemented; I would just copy how you did it; and try to duplicate that work, and apply it to this feature.

I could also do it both ways; and have the HTML Injector allow you to add more code to the page; while giving the CMS the ability to manage the Header and Footer in the back end; with no HTML code required; this requires template changes, and an extra footer field.

As the CMS is: we have no Header or Footer at start up out of the Box; and you would have to edit the Templates to accomplish this task if you wanted this feature to begin with; so its easy enough for anyone to do that now; without the Footer database code; and if you hard code it, you would have to do the same time by first updating the Template; and the database fields; and its not that hard to do; but its work, and I would always rather do things the right way the first time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant