Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests have started to fail with HAARG/HTTP-Tiny-0.090.tar.gz #7

Open
andk opened this issue Nov 30, 2024 · 1 comment
Open

Tests have started to fail with HAARG/HTTP-Tiny-0.090.tar.gz #7

andk opened this issue Nov 30, 2024 · 1 comment

Comments

@andk
Copy link

andk commented Nov 30, 2024

Pass report with 0.088: http://www.cpantesters.org/cpan/report/f69232b8-af4a-11ef-973c-f257d67c2c52
Fail report with same perl and 0.090: http://www.cpantesters.org/cpan/report/a08dec44-af4b-11ef-8405-755fd67c2c52

@haarg , could you chime in please? -- Thanks!

@haarg
Copy link

haarg commented Dec 1, 2024

This is caused by Perl-Toolchain-Gang/HTTP-Tiny@9fcfe7c

HTTP::Tiny is no longer sorting the values when given query parameters with an array ref of values. I believe this is the correct behavior.

WebService::S3::Tiny signs the requests that it makes, so it is sensitive to the exact content of the requests it generates. As far as I can tell, the module itself is working fine and will work properly with the new HTTP::Tiny version. But the tests have hard coded signatures to expect, and explicitly test for the sorting behavior.

I believe this module's tests should be updated, either to avoid testing this behavior or to depend on the new version and expect its output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants