Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find a better place to job status switcher #2082

Closed
2 tasks done
bigred94 opened this issue Aug 25, 2020 · 4 comments · Fixed by #2357
Closed
2 tasks done

Find a better place to job status switcher #2082

bigred94 opened this issue Aug 25, 2020 · 4 comments · Fixed by #2357
Assignees
Labels
enhancement New feature or request

Comments

@bigred94
Copy link

bigred94 commented Aug 25, 2020

My actions before raising this issue

I don't have an option to change status of job.
Screen Shot 2020-08-25 at 8 52 48 AM
Additionally the enumeration type for the status of the job in enums.js is called TaskStatus. I think the name of this should be changed since it is referring to a task not a job.

Expected Behaviour

The menu on the annotation page gives option to change status.

Current Behaviour

Possible Solution

Steps to Reproduce (for bugs)

Context

Your Environment

  • Git hash commit (git log -1): 1fdf100
  • Docker version docker version (e.g. Docker 17.0.05):
  • Are you using Docker Swarm or Kubernetes?
  • Operating System and version (e.g. Linux, Windows, MacOS): MacOS
  • Code example or link to GitHub repo or gist to reproduce problem:
  • Other diagnostic information / logs:
    Logs from `cvat` container

Next steps

You may join our Gitter channel for community support.

@bsekachev
Copy link
Member

@bigred94

Hi, please look at #1704
Job and task statuses are the same.
A task status is changing automatically depends of job statuses of the task

@bigred94
Copy link
Author

@bsekachev

Thanks for pointing me to #1704 that helped me find how to change the status! I would recommend changing the following in the documentation to use the Info button not the menu inside the job. I do realize it references the info button later on in the documentation, but making the change here would help too.

"A status of the job. The status is specified by the user in the menu inside the job. There are three types of status: annotation, validation or completed. The status of the job is changes the progress bar of the task."

I understand that a task which has the states "pending", "in progress", and "completed" changes automatically as the jobs statuses change. However, in enums.js the enumeration TaskStatus has the states, 'annotation', 'validation', and 'completed'. As mentioned these are not the states of a Task, they are the states of a Job so the name TaskStatus should be changed to reflect that.

@bsekachev
Copy link
Member

Hmm.. you are right. In UI task status is defined as following:

        if (numOfCompleted === numOfJobs) {
            progressColor = 'cvat-task-completed-progress';
            progressText = <Text strong className={progressColor}>Completed</Text>;
        } else if (numOfCompleted) {
            progressColor = 'cvat-task-progress-progress';
            progressText = <Text strong className={progressColor}>In Progress</Text>;
        } else {
            progressColor = 'cvat-task-pending-progress';
            progressText = <Text strong className={progressColor}>Pending</Text>;
        }

But it is only UI implementation. In the database task status is one of

class StatusChoice(str, Enum):
    ANNOTATION = 'annotation'
    VALIDATION = 'validation'
    COMPLETED = 'completed'

as you can see here: cvat/apps/engine/models.py

Maybe we should sort it out.

@bsekachev
Copy link
Member

What's more, we wanted rename 'validation' to 'review'

@bsekachev bsekachev changed the title Unable to change status of Job Find a better place to job status switcher Aug 26, 2020
@bsekachev bsekachev added the enhancement New feature or request label Aug 26, 2020
@bsekachev bsekachev self-assigned this Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants