Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset Zoom not honored in Tag Annotation mode #2174

Closed
2 tasks done
rorph opened this issue Sep 14, 2020 · 0 comments · Fixed by #2443
Closed
2 tasks done

Reset Zoom not honored in Tag Annotation mode #2174

rorph opened this issue Sep 14, 2020 · 0 comments · Fixed by #2443
Assignees
Labels
bug Something isn't working
Milestone

Comments

@rorph
Copy link

rorph commented Sep 14, 2020

My actions before raising this issue

Expected Behaviour

Reset Zoom functionality should work

Current Behaviour

When annotating in Tag Annotation mode, Reset Zoom option on Settings is ignored and image is always set to fit canvas.

Possible Solution

Apparently the culprid is the canvasInstance.fit() at canvas-wrapper:

            if (workspace === Workspace.ATTRIBUTE_ANNOTATION) {
                if (activatedState.objectType !== ObjectType.TAG) {
                    canvasInstance.focus(activatedStateID, aamZoomMargin);
                } else {
                    canvasInstance.fit();
                }
            }

Steps to Reproduce (for bugs)

  1. Uncheck Reset Zoom
  2. Switch to Tag Annotation
  3. Zoom out and go to next image

Your Environment

  • Live version
@bsekachev bsekachev added the enhancement New feature or request label Sep 15, 2020
@bsekachev bsekachev self-assigned this Sep 15, 2020
@bsekachev bsekachev added this to the 1.2.0-alpha milestone Sep 15, 2020
@nmanovic nmanovic modified the milestones: 1.2.0-alpha, 1.2.0-beta Nov 9, 2020
@bsekachev bsekachev added bug Something isn't working and removed enhancement New feature or request labels Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants