Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intelligent Scissors add documentation #2765

Closed
2 tasks done
bsekachev opened this issue Feb 3, 2021 · 7 comments
Closed
2 tasks done

Intelligent Scissors add documentation #2765

bsekachev opened this issue Feb 3, 2021 · 7 comments
Labels
documentation Documentation should be updated

Comments

@bsekachev
Copy link
Member

My actions before raising this issue

Need to add a piece of documentation to the user guide about the feature of intelligent scissors #2689 (how to use, etc)

@bsekachev bsekachev added the documentation Documentation should be updated label Feb 3, 2021
@bsekachev bsekachev added this to the 1.3.0-alpha milestone Feb 3, 2021
@nmanovic
Copy link
Contributor

nmanovic commented Feb 3, 2021

@aschernov , could you please look at the issue?

@aschernov
Copy link
Contributor

@bsekachev , how can we test this function? Seems the tool hasn't been updated yet.

@bsekachev
Copy link
Member Author

bsekachev commented Feb 8, 2021

@aschernov The server was updated, Please, additional to the documentation provide a feedback to the feature (what is good, what is wrong, what errors you met, etc.)

UPD: I found something doesn't work now, will fix ASAP and notify you additionally.

@bsekachev
Copy link
Member Author

@aschernov Fixed.

@azhavoro We have separated cvat-proxy for cvat.org and the internal server. I've updated them (to get opencv works), should we commit the changes or left it as is?

@aschernov
Copy link
Contributor

What is good:

  1. The tool is well-suited for annotation of complex shapes on a contrast background.
    1
    2
  2. The main advantage of the tool is an option to see the final line and change the line in the process.
  3. In comparison with the manual method, using the tool is much faster for creating lines with many points.
    3
    I suggest adding the option to create points (like in case with polygon drawing). It could be done in a following way: for example, holding the Shift key would make “intelligent scissors” function as a polygon thus the points would be connected by a straight line. This addition would allow to combine manual and automatic drawing.

What is wrong:

  1. Fully finished polygons often have two points in one place
  2. Sometimes there are strong deviations of automatically created line which are difficult to control because even the slightest cursor shift creates different lines
    opencv1
  3. It is necessary to add an option of "automatic bordering" for existing polygons. It would help in tasks where you need to allocate all objects in the frame without empty areas.
    4
    5
  4. Sometimes when new points are created quickly, the following message is displayed:
    RuntimeError: float unrepresentable in integer range
    8111568 - Exception catching is disabled, this exception cannot be caught. Compile with -s DISABLE_EXCEPTION_CATCHING=0 or DISABLE_EXCEPTION_CATCHING=2 to catch.
  5. The cursor and the square are poorly visible
  6. It is necessary to add a limit to the possible size of the threshold or a warning about possible slowdown of the working process (when the action threshold is very big the performance is low).
  7. Due to the square shape of the action's threshold, it turns out that diagonal lines can be longer than horizontal and vertical ones. Perhaps, it would be better to develop an option to rotate the square or change the action's threshold shape to a circle instead of the square.

@bsekachev
Copy link
Member Author

@aschernov

Thanks for the feedback. I'll create a separate issue with these cons.

@bsekachev
Copy link
Member Author

Created issue #2800

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation should be updated
Projects
None yet
Development

No branches or pull requests

3 participants