Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore image regions with a mask #251

Closed
alex-klimov opened this issue Nov 15, 2022 · 4 comments
Closed

Ignore image regions with a mask #251

alex-klimov opened this issue Nov 15, 2022 · 4 comments

Comments

@alex-klimov
Copy link

Colmap allows to ignore regions of the image for a feature extraction by providing a mask:
https://colmap.github.io/faq.html#mask-image-regions

Does HLoc support similar functionality? I need that to ignore dynamic object in otherwise static scene.

@sarlinpe
Copy link
Member

There is already a PR for it: #190 It is outdated and I do not plan to merge it but it is straightforward to add.

@alex-klimov
Copy link
Author

Thank you! I will take a look.

@Shubodh
Copy link

Shubodh commented Nov 29, 2022

@skydes Could you expand on what you mean by "It is outdated"? Do you mean there is a better way of doing PR #190 , i.e. better masking approach? Any references would help.

@sarlinpe
Copy link
Member

It is outdated in the sense that extract_features has seen many changes on the main branch. You might want to load the masks in the dataloader for better performance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants