-
Notifications
You must be signed in to change notification settings - Fork 583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Superpoint + superglue w/ hloc give 90 degree camera orientation error #362
Comments
Hi, a gentle bump on this. 90 degree orientation error for most cameras seems like it is a bug in the hloc source code. Thanks! |
This indeed looks like a problem, I'll investigate once I find the time. Thank you for reporting this! |
Found the culprit - PR #373 solves this bug. Unfortunately SuperPoint+SuperGlue cannot match 90-degree rotated images, so for now hloc registers only 26/35 images (those in portrait mode). Fixing this is pretty high on our priority list. For now I suggest baking the EXIF rotation into the images by reading+writing them with OpenCV:
This prevents COLMAP from sharing intrinsics between rotated images but the negative impact should be negligible. |
Hi, thanks for making this repo and the notebooks.
I tried out the superpoint+superglue+colmap notebook here
https://github.com/cvg/Hierarchical-Localization/blob/master/pipeline_SfM.ipynb
using the 35-image dataset here: http://vision.maths.lth.se/calledataset/de_guerre/de_guerre.zip
It seems superpoint+superglue w/ HLOC estimates most camera orientations incorrectly by 90 degrees error about the +z camera axis (roll). I don't see any such issue with vanila COLMAP. I wonder if you could try reproducing or investigating this result?
Thanks again!
The text was updated successfully, but these errors were encountered: