Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is the max_angle in superpoint+lightglue_homography.yaml set to 45 degrees? #126

Open
ChangHsinChih opened this issue Apr 25, 2024 · 2 comments

Comments

@ChangHsinChih
Copy link

When I use two images with large rotation angles, I notice that the matching performance is poor. I'm wondering if increasing the max_angle would improve the performance?
HorizontalRotation-29-sp+lg

@Phil26AT
Copy link
Collaborator

Phil26AT commented Apr 26, 2024

Hey @lgdtd3

Thank you for opening this issue. Indeed in-plane rotations are a limitation of the work, and this is partially inherited from the descriptors. Because we do not train the descriptors, and because most images are roughly upright, we trained the model with 45 degree augmentations (note that this results in up to 90 degree relative rotation for an image pair). Also, most of the images in MegaDepth are upright, too, so you also have to add rotations there.

You could try to improve the rotation robustness of LightGlue by increasing this angle, but I doubt it would solve the issue (it could work with SIFT). Alternatively, you could also manually rotate one of the images by 90/180/270 degrees and select the pair with most matches.

@blackjacket996
Copy link

Yeah,using a trick like rotating the image before would bring a better result. I've tried it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants