Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gsoc practice linting #132

Closed
cvvergara opened this issue May 15, 2017 · 2 comments
Closed

Gsoc practice linting #132

cvvergara opened this issue May 15, 2017 · 2 comments
Labels

Comments

@cvvergara
Copy link
Owner

cvvergara commented May 15, 2017

Learning the basics of linting code
Please add the task to your issues in your fork

depart from develop: (I am assuming that you already updated your fork)

git checkout develop
git checkout -b lint/trsp
git push

do the linting

git push

and make a pull request to main repo's develop

@cvvergara
Copy link
Owner Author

cvvergara commented May 15, 2017

  • The .vimrc

If you are using vi or vim editor edit .vimrc in your home folder to look like:

syntax on
filetype plugin indent on
" show existing tab with 4 spaces width
set tabstop=4
" when indenting with '>', use 4 spaces width
set shiftwidth=4
" On pressing tab, insert 4 spaces
set expandtab

other editors set the tab to be four spaces instead of a tab

@cvvergara
Copy link
Owner Author

name lint what
Mao src/trsp/src/GraphDefinition.h
Ankur src/trsp/src/trsp_driver.h
Vid everything else that you want that is not assigned to the others

The reason for Vid to do more linting is that he will be working on a rewrite of trsp and linting code will give him a chance of looking at "what no to do"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant