Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMPOSER_EXIT_ON_PATCH_FAILURE doesn't do anything #359

Closed
grasmash opened this issue Mar 23, 2021 · 4 comments
Closed

COMPOSER_EXIT_ON_PATCH_FAILURE doesn't do anything #359

grasmash opened this issue Mar 23, 2021 · 4 comments

Comments

@grasmash
Copy link
Contributor

I've searched through the code and it doesn't appear to be used at all?

@cweagans
Copy link
Owner

@grasmash
Copy link
Contributor Author

Thank you. I've yet to validate that COMPOSER_PATCHES_EXIT_ON_PATCH_FAILURE, but I'll do some testing.

@mohammadzo
Copy link

@cweagans I am running my command like the following and it will still exit. Any idea how to fix it?
COMPOSER_PATCHES_EXIT_ON_PATCH_FAILURE=1 composer update drupal/core --with-all-dependencies

I have the "composer-exit-on-patch-failure": true, in the composer.json and I want to skip it while I am running my command.

Could you please help ?

@bobbygryzynger
Copy link

bobbygryzynger commented Jul 27, 2022

I'm seeing that COMPOSER_EXIT_ON_PATCH_FAILURE is used in the latest release (1.7.2): https://github.com/cweagans/composer-patches/blob/1.7.2/src/Patches.php#L285.

If I set that, a patching failure causes composer install to exit with a non-zero value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants