Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] sql escape - auto #1371

Open
arunaseva opened this issue Dec 24, 2024 · 1 comment
Open

[BUG] sql escape - auto #1371

arunaseva opened this issue Dec 24, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@arunaseva
Copy link

arunaseva commented Dec 24, 2024

EDIT: I corrected 'Never' to 'Always' in text.

Hello,

I have a table with name: signal
This is a reserved word: https://mariadb.com/kb/en/reserved-words/

=====================================================
I got error With this settings (Auto):
Settings->SQL: Escaped all object name-> Auto

So when I click the table name (in left panel) this sql run:
https://mariadb.com/kb/en/reserved-words/
and I got the error:
(conn:227, no: 1064, SQLState: 42000) You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'signal LIMIT 100' at line 1 sql: SELECT * FROM signal LIMIT 100 - parameters:[]

=====================================================

With the setting (Always) all works fine but all table and column name are escaped.

I rarely use reserved word in table or in column name -> I don't need the lot of escaping for nothing, so 'Always' settings not so attractive for me.

So I suggest two possible fix:

  1. Use mariadb reserved words (linked) at 'Auto' setting, and then only signal will be escaped in sql with 'Auto' mode.

  2. Add possibility for 'Auto' settings to add words manually, so I can add 'signal' word manually. So user can add any individual exception if needed.

Thanks to consider my suggestions.
Keep up the great work with the development.
Adam

My database type and version: 11.4.4-MariaDB (windows 11)
I'm on Premium plan.

@arunaseva arunaseva added the bug Something isn't working label Dec 24, 2024
@cweijan
Copy link
Owner

cweijan commented Dec 24, 2024

Thank you for your feedback, I will support this keyword in the next version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants