Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Can NOT display correctly in the DIFF view. #279

Closed
Nigh opened this issue Dec 5, 2023 · 2 comments
Closed

[BUG] Can NOT display correctly in the DIFF view. #279

Nigh opened this issue Dec 5, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@Nigh
Copy link

Nigh commented Dec 5, 2023

  • OS: Windows 11 22H2
  • Extension Version: v3.1.8

I think the markdown view should be disabled in the DIFF view.

@Nigh Nigh added the bug Something isn't working label Dec 5, 2023
@Vigilans
Copy link

Vigilans commented Jan 6, 2024

Ref #183 (comment):

According to microsoft/vscode#138525 (comment), diff editor has its own resource url git:/... or gitlens:/..., so can be specified to use default editor view in workbench.editorAssociations:

    "workbench.editorAssociations": {
        "{git,gitlens}:/**/*.{md,csv}": "default"
    },

As such vscode-office's rendering is disabled in diff view.

NOTE: Due to a bug in vscode: editorResolverService.ts#L166-L181, specifying different editor type for normal view and diff view will make both page in diff view regress into default view. This is because in diff view, left side url is git:/..., while right side url is actually file:/....

@cweijan
Copy link
Owner

cweijan commented Mar 4, 2024

Fixed in version 3.2.0.

@cweijan cweijan closed this as completed Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants