Add specific dispatch.callSync exception for method-not-found

Christopher Willis-Ford · Christopher Willis-Ford · commit 293e49e639c0 · 2019-07-29T21:54:37.000-07:00
diff --git a/src/dispatch/central-dispatch.js b/src/dispatch/central-dispatch.js
@@ -50,7 +50,11 @@ class CentralDispatch extends SharedDispatch {
                 throw new Error(`Cannot use 'callSync' on remote provider for service ${service}.`);
             }
 
-            return provider[method].apply(provider, args);
+            const func = provider[method];
+            if (!func) {
+                throw new Error(`Method ${method} not found on service ${service}`);
+            }
+            return func.apply(provider, args);
         }
         throw new Error(`Provider not found for service: ${service}`);
     }

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,11 @@ class CentralDispatch extends SharedDispatch {`
`50`	`50`	throw new Error(`Cannot use 'callSync' on remote provider for service ${service}.`);
`51`	`51`	`}`
`52`	`52`
`53`		`- return provider[method].apply(provider, args);`
	`53`	`+ const func = provider[method];`
	`54`	`+ if (!func) {`
	`55`	+ throw new Error(`Method ${method} not found on service ${service}`);
	`56`	`+ }`
	`57`	`+ return func.apply(provider, args);`
`54`	`58`	`}`
`55`	`59`	throw new Error(`Provider not found for service: ${service}`);
`56`	`60`	`}`