Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shift to another hasmap implementation from the deprecated c_hashmap #826

Open
rootkea opened this issue Oct 13, 2023 · 2 comments
Open

Comments

@rootkea
Copy link
Contributor

rootkea commented Oct 13, 2023

Hello!

Currently, we are using c_hashmap https://github.com/petewarden/c_hashmap which has been deprecated and suggests https://github.com/sheredom/hashmap.h as a replacement.

From https://github.com/petewarden/c_hashmap/blob/master/README:
"This version is now deprecated, since it's unmaintained. @sheredom has a newer version at https://github.com/sheredom/hashmap.h"

I researched a bit and these are some of the popular hashmap implementations:

  1. https://github.com/sheredom/hashmap.h (suggested by c_hashmap)
  2. https://github.com/skarupke/flat_hash_map
  3. https://github.com/greg7mdp/parallel-hashmap
  4. https://github.com/khizmax/libcds

IMHO, we should move to any of these or any other active hashmap implementation from the current deprecated c_hashmap.

@rootkea
Copy link
Contributor Author

rootkea commented Oct 13, 2023

I can take this one if https://github.com/sheredom/hashmap.h sounds as an apt alternative.

@cxong
Copy link
Owner

cxong commented Dec 26, 2023

Sure, happy to review a PR that implements this, but please make sure we regression test all the places that use hashmaps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants