Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to tap cask on Apple silicon #41

Closed
1 of 3 tasks
fangel opened this issue Feb 14, 2022 · 9 comments · Fixed by #47
Closed
1 of 3 tasks

Unable to tap cask on Apple silicon #41

fangel opened this issue Feb 14, 2022 · 9 comments · Fixed by #47

Comments

@fangel
Copy link

fangel commented Feb 14, 2022

Summary

If you try to do brew tap cyberark/tools on a Apple sillicon computer (M1-powered) you get an error about missing url in Serverless-broker

Steps to Reproduce

  1. brew tap cyberark/tools

It's possible it can be reproduced on non-Apple silicon using arch -arm64 brew tap cyberark/tools (you'll probably need to untap first, then tap with the arch changed)

Expected Results

The cask is tapped successfully.

Actual Results

Error: Invalid formula: /opt/homebrew/Library/Taps/cyberark/homebrew-tools/secretless-broker.rb
formulae require at least a URL

This is likely because the formulae for secreless-broken only defines the url inside a if that looks for the hardware arch.

If the app in question only exists for Intel-powered Macs, it's might be possible to use something like depends_on arch: :intel in the Formulae (see https://docs.brew.sh/Cask-Cookbook#depends_on-arch).
It will still need to set the url-property, but it'll refuse to install on Apple silicon, which is better than the whole cask failing.

Reproducible

  • Always
  • Sometimes
  • Non-Reproducible

Environment setup

  • Apple Silicon powered laptop
@rpothier
Copy link
Contributor

rpothier commented Mar 2, 2022

With PR secretless-broker 1456 secretless-broker.rb should get updated and should fix the issue when released.

@tabacco
Copy link
Contributor

tabacco commented Apr 13, 2022

I see that PR is merged, but there are still no arm64 builds available and the tap still won't work on arm macs.

@rpothier
Copy link
Contributor

@tabacco The components get updated in homebrew when they are released. We have scheduled the components for release.

@dzasorki
Copy link

Hey team, when approximately can we see this PR on prod? Does anyone know the approximate date?
Thank you!

@rpothier
Copy link
Contributor

rpothier commented May 2, 2022

Hi @dzasorki Secretless-broker and summon-aws-secrets are scheduled to be released in the next two weeks. The other components have already been updated for Apple silicon.

@szh szh closed this as completed May 19, 2022
@tabacco
Copy link
Contributor

tabacco commented May 19, 2022

Hi, you closed this, but the issue doesn't appear to be resolved:

 brew tap cyberark/tools
==> Tapping cyberark/tools
Cloning into '/opt/homebrew/Library/Taps/cyberark/homebrew-tools'...
remote: Enumerating objects: 292, done.
remote: Counting objects: 100% (103/103), done.
remote: Compressing objects: 100% (55/55), done.
remote: Total 292 (delta 49), reused 88 (delta 48), pack-reused 189
Receiving objects: 100% (292/292), 68.98 KiB | 811.00 KiB/s, done.
Resolving deltas: 100% (146/146), done.
Error: Invalid formula: /opt/homebrew/Library/Taps/cyberark/homebrew-tools/secretless-broker.rb
formulae require at least a URL
Error: Cannot tap cyberark/tools: invalid syntax in tap!

secretless-broker.rb in master is still missing an arm release: https://github.com/cyberark/homebrew-tools/blob/master/secretless-broker.rb

@szh
Copy link
Contributor

szh commented May 19, 2022

Sorry, my bad. Looks like we're still waiting for a release on secretless-broker. I'll see if we can get that in quickly.

@szh szh reopened this May 19, 2022
@szh szh self-assigned this May 19, 2022
@tabacco
Copy link
Contributor

tabacco commented May 19, 2022

Looks like the last two secretless-broker releases were marked as pre-release, so they didn't update the homebrew formula

@tabacco
Copy link
Contributor

tabacco commented May 20, 2022

It works! Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants