Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postgres handler supports sslrootcert and sslmode up to verify-ca #535

Closed
7 tasks
jonahx opened this issue Nov 30, 2018 · 0 comments
Closed
7 tasks

Postgres handler supports sslrootcert and sslmode up to verify-ca #535

jonahx opened this issue Nov 30, 2018 · 0 comments

Comments

@jonahx
Copy link
Contributor

jonahx commented Nov 30, 2018

A.C.

  • handler credentials accepts sslmode and sslrootcert
  • [default] When a connection is made to a server:
    • FAIL, if the server does not support TLS
    • DO NOT VERIFY, if no root CA is present
    • VERIFY the server certificate (same as verify-ca), if a root CA file is present
  • When a connection is made to a server:
    • FAIL, if client requires TLS and server does not support it
    • DO NOT USE TLS, if sslmode=disable
    • ONLY USE TLS, if sslmode=prefer and server supports TLS
  • test cases exist for each of the scenarios above

Checklist

The default case is handled by previous stories. We just need to add tests for
verifying the CA cert and for the lower options.

  • fails if root CA present and doesn't match
  • succeeds if root CA present and does match
  • fails if TLS required but server doesn't support it
  • succeeds without TLS if sslmode=disable
  • if ssl mode is prefer, succeeds and uses TLS when server supports it
  • if ssl mode is prefer, succeeds without TLS when server doesn't support it
  • docs are updated again to reflect support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants