Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Go client version #288

Closed
telday opened this issue Jan 26, 2021 · 5 comments
Closed

Bump Go client version #288

telday opened this issue Jan 26, 2021 · 5 comments

Comments

@telday
Copy link

telday commented Jan 26, 2021

Is your feature request related to a problem? Please describe.

The Go client was updated to retrieve batch secrets using the Accept: base64 header in order to avoid encoding errors in Conjur. This secrets provider should be updated to use the new version of the client which includes this update.

Additional context

Here is the original issue referencing the use of secrets provider for k8s.

@orenbm
Copy link
Member

orenbm commented Jan 26, 2021

thanks for creating this issue @telday !

The secrets-provider uses the conjur-api-go for retrieving secrets so the fix will go there.

Just to clarify - to use this feature we need to add the new header and then base-64 decode each secret in the JSON object?

@telday
Copy link
Author

telday commented Jan 26, 2021

@orenbm yes, that is the planned implementation, @izgeri recommended editing the go client requests to the batch secrets endpoint to use the new header and automatically decode the returned JSON

@izgeri
Copy link
Contributor

izgeri commented Jan 26, 2021

@orenbm yup!

I think we would update the go client so that this request
https://github.com/cyberark/conjur-api-go/blob/b3f7d8f046f8d48d072fa028217d1add8a5a294e/conjurapi/router_v5.go#L141
sends the header, and this method base64 decodes it: https://github.com/cyberark/conjur-api-go/blob/b3f7d8f046f8d48d072fa028217d1add8a5a294e/conjurapi/variable.go#L27

then the secrets provider would just have to bump its go client version.

@orenbm
Copy link
Member

orenbm commented Jan 26, 2021

beauty!

@telday telday self-assigned this Jan 26, 2021
@telday telday changed the title Update secrets provider to retrieve batch secrets base64-encoded Bump Go client version Jan 26, 2021
@izgeri
Copy link
Contributor

izgeri commented Mar 30, 2021

Note: the server was changed, so we'll actually want to change this to use v0.7.2 of the go client, to be released in cyberark/conjur-api-go#102

@szh szh closed this as completed Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

4 participants