Skip to content
This repository has been archived by the owner on Dec 22, 2019. It is now read-only.

Converting type to typ3 with considering options. #24

Closed
Thunnini opened this issue Dec 4, 2018 · 3 comments
Closed

Converting type to typ3 with considering options. #24

Thunnini opened this issue Dec 4, 2018 · 3 comments
Assignees
@Thunnini

Comments

@Thunnini
Copy link
Contributor

Thunnini commented Dec 4, 2018

Currently, js-amino convert type to typ3 with considering only type.
So, when encoding int with bin-fixed option, js-amino can't get valid typ3.
So js-amino needs to consider options when converting type to typ3.
@Thunnini
Copy link
Contributor Author

Thunnini commented Dec 4, 2018

I assign this issue to myself... But, I can't assign this issue in github, and I don't know why...

@Thunnini Thunnini mentioned this issue Dec 4, 2018
Closed
@TanNgocDo
Copy link
Contributor

I have just sent you an invitation. Could you please check ?

@Thunnini Thunnini self-assigned this Dec 5, 2018
@Thunnini
Copy link
Contributor Author

Thunnini commented Dec 5, 2018 •
edited
Loading

I can assign. Thank you!

@Thunnini Thunnini mentioned this issue Dec 6, 2018
Merged
@Thunnini Thunnini closed this as completed Dec 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Thunnini Thunnini

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TanNgocDo @Thunnini