Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Support pnpm v9 #9

Open
tuanphamcybozu opened this issue Jun 19, 2024 · 0 comments
Open

[Feature Request] Support pnpm v9 #9

tuanphamcybozu opened this issue Jun 19, 2024 · 0 comments

Comments

@tuanphamcybozu
Copy link

tuanphamcybozu commented Jun 19, 2024

Why

  • pnpm has released version 9, which has many major and minor changes from version 8.
    Ref: https://github.com/pnpm/pnpm/releases/tag/v9.0.0

  • @cybozu/license-manager is currently not support pnpm v9.

  • This incompatibility has a direct impact on projects using @cybozu/license-manager. Attempting to upgrade pnpm to v9 results in a failed GitHub actions job, specifically related to the analyze and extract functions.

What

  • Make @cybozu/license-manager support pnpm v9. So that project using @cybozu/license-manager can upgrade pnpm without any concerns.

Reproduce

Run pnpm license:analyze
  pnpm license:analyze
  pnpm license:extract
  shell: /usr/bin/bash -e {0}
  env:
    PNPM_HOME: /home/runner/setup-pnpm/node_modules/.bin

> @kintone/cli-kintone@1.10.13 license:analyze /home/runner/work/cli-kintone/cli-kintone
> license-manager analyze -c license-manager.config.js

🔎 Analyzing dependencies...
💡 Detected license-manager.config.js
✅ All dependencies confirmed

> @kintone/cli-kintone@1.10.13 license:extract /home/runner/work/cli-kintone/cli-kintone
> license-manager extract -c license-manager.config.js

🔪 Extract licenses...
💡 Detected license-manager.config.js
/home/runner/work/cli-kintone/cli-kintone/node_modules/.pnpm/@cybozu+license-manager@1.[2](https://github.com/kintone/cli-kintone/actions/runs/9448860916/job/26023788533#step:7:2).1/node_modules/@cybozu/license-manager/dist/functions/getLicenseText.js:14
        throw new Error("invalid dep: " + dep);
              ^

Error: invalid dep: [object Object]
    at getLicenseText (/home/runner/work/cli-kintone/cli-kintone/node_modules/.pnpm/@cybozu+license-manager@1.2.1/node_modules/@cybozu/license-manager/dist/functions/getLicenseText.js:14:15)
    at /home/runner/work/cli-kintone/cli-kintone/node_modules/.pnpm/@cybozu+license-manager@1.2.1/node_modules/@cybozu/license-manager/dist/functions/aggregate.js:21:102
    at Array.map (<anonymous>)
    at aggregate (/home/runner/work/cli-kintone/cli-kintone/node_modules/.pnpm/@cybozu+license-manager@1.2.1/node_modules/@cybozu/license-manager/dist/functions/aggregate.js:18:29)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async extract (/home/runner/work/cli-kintone/cli-kintone/node_modules/.pnpm/@cybozu+license-manager@1.2.1/node_modules/@cybozu/license-manager/dist/extract.js:18:26)

Node.js v18.20.[3](https://github.com/kintone/cli-kintone/actions/runs/9448860916/job/26023788533#step:7:3)
 ELIFECYCLE  Command failed with exit code 1.
Error: Process completed with exit code 1.

Note

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant