Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript warnings #139

Closed
ricochet1k opened this issue Sep 26, 2016 · 5 comments
Closed

TypeScript warnings #139

ricochet1k opened this issue Sep 26, 2016 · 5 comments

Comments

@ricochet1k
Copy link

When using Typescript with webpack, I get a several warnings from cyclic-router like this:

WARNING in ./~/cyclic-router/lib/index.js
Cannot find source file '../src/index.ts': Error: Cannot resolve 'file' or 'directory' ../src/index.ts in /web-cycle/node_modules/cyclic-router/lib

Can you include the typescript files in the npm package?

@TylorS
Copy link
Member

TylorS commented Sep 26, 2016

They are distributed via NPM

https://github.com/cyclejs-community/cyclic-router/blob/master/package.json#L6

If you could provide more information perhaps it'd be easier to know how to help

@ricochet1k
Copy link
Author

Source maps in webpack seem to want the original src/ files, which are being ignored by your .npmignore.

Some examples:

@ricochet1k
Copy link
Author

Thanks for looking into this by the way.

@TylorS
Copy link
Member

TylorS commented Sep 26, 2016

Okay, I'll remove the src/ directory from the .npmignore later tonight

@kylecordes
Copy link
Contributor

I think this is fixed and can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants