Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

createHref doesn't behave as expected #213

Open
ntilwalli opened this issue Jun 3, 2018 · 0 comments
Open

createHref doesn't behave as expected #213

ntilwalli opened this issue Jun 3, 2018 · 0 comments

Comments

@ntilwalli
Copy link
Collaborator

ntilwalli commented Jun 3, 2018

I'm posting this as a note of something to possibly update in the future...

The code for path never allows an empty string to be added to the _namespace meaning when trying to construct a path using join there is never a scenario where a '/' is the first character so all constructed paths are relative. In my app I want all the paths to be absolute from root so the createHref functionality feels broken. I'm doing [""].concat(Router._namespace).join('/') directly in my code to create the current relative path. I feel likecreateHref should be changed to use that approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant