Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

todomvc-cycle becomes very slow with a lot of items (blocking script) #22

Closed
sebastiendavid opened this issue Jan 23, 2016 · 3 comments
Closed

Comments

@sebastiendavid
Copy link

Hi,

First: congrats for the job done with cycle.js, I like the ideas behind this framework.

Now the problem I see is about a list with a lot of children observed by RxJS. In this todomvc example you can fill the localstorage with 2000 items, and see by yourself.

Here the way I produce the slowness by executing this in my developer tools and refreshing the page:

var store = { list: [] };
for (var i = 1; i <= 2000; i++) {
  store.list.push({ title: 'Todo' + i, completed: false, id: i });
}
localStorage.setItem('todos-cycle', JSON.stringify(store));

After this, complete a todo by clicking on it, and you can see a lot of scripting (mostly RxJS stuff):

screen shot 2016-01-23 at 17 43 41

Of course I think that 2000 todos is a little dumb :D, but maybe it make sense in another kind of app.

@staltz
Copy link
Member

staltz commented Feb 3, 2016

Thanks, we'll revise this once we get Cycle working with RxJS 5 and most.js.

@Frikki
Copy link
Member

Frikki commented Oct 5, 2016

Is this still relevant?

@sebastiendavid
Copy link
Author

I just tested it, it's a lot better 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants