Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POI ID changed to string #554

Closed
HilaryN opened this issue Apr 27, 2024 · 9 comments · Fixed by #555
Closed

POI ID changed to string #554

HilaryN opened this issue Apr 27, 2024 · 9 comments · Fixed by #555

Comments

@HilaryN
Copy link
Contributor

HilaryN commented Apr 27, 2024

Creating new issue for this.

@mvl22
Copy link
Member

mvl22 commented Apr 27, 2024

IDs look like this string:

cycleparking-n943984

If it's possible to prioritise a fix for this issue, that would be good - we are continually getting feedback on this, and it feels like this ought to be fairly simple to fix I suspect.

@mvl22
Copy link
Member

mvl22 commented May 5, 2024

How is this looking? Is this ready to push to the beta channel?

@oliverlockwood
Copy link
Member

@mvl22 all being well, Travis will push this to the beta channel shortly

@mvl22
Copy link
Member

mvl22 commented May 7, 2024

Travis will push this to the beta channel shortly

Excellent, thanks.

Assuming the fix works and nothing breaks, could we push this to the live channel fairly quickly? I'm keen to get back to the various people who reported the problem.

@oliverlockwood
Copy link
Member

Give a shout when it's been validated in beta and I'll do my best

@mvl22
Copy link
Member

mvl22 commented May 8, 2024

All working correctly on my test Android device. Great to have the POIs visible again :)

@mvl22
Copy link
Member

mvl22 commented May 16, 2024

Are we able to get a release out now?

I am mindful of #522 which will, from end of May, block releases until we implement that, so we just get the POIs release out ASAP, and then I will get the new user.delete API working that will be a precondition for Android app releases from June.

@oliverlockwood
Copy link
Member

oliverlockwood commented May 17, 2024

@mvl22 I have now requested promotion of the new release to production. It's been "sent to Google for review", apparently they "usually" deal with this within 7 days.

A couple of warnings popped up during the process which might be ones for you to look at:
Screenshot 2024-05-17 at 14 31 24

@mvl22
Copy link
Member

mvl22 commented May 17, 2024

Thanks; it's hard keeping up with their various forms sometimes, as they don't seem to e-mail them always.

I've updated the outstanding forms:

Looks like the release is live - thanks:

https://play.google.com/store/apps/details?id=net.cyclestreets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants