Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cycleway not rendered through tunnel #234

Closed
DaveF63 opened this issue Nov 2, 2019 · 7 comments · Fixed by #252
Closed

Cycleway not rendered through tunnel #234

DaveF63 opened this issue Nov 2, 2019 · 7 comments · Fixed by #252
Labels
bug Something isn't working
Milestone

Comments

@DaveF63
Copy link

DaveF63 commented Nov 2, 2019

Hi
https://www.cyclosm.org/#map=15/51.3639/-2.3492

Is there a specific reason Cycleways are not rendered through tunnels?
https://www.openstreetmap.org/way/39042117#map=17/51.36990/-2.36594

@Florimondable
Copy link
Member

No, this is a bug.
But I can't understand why it's not drawn where as here it's ok https://www.cyclosm.org/#map=19/48.86459/2.31979/cyclosm
https://www.openstreetmap.org/way/724081039

@Florimondable
Copy link
Member

Florimondable commented Nov 2, 2019

Same issue here https://www.openstreetmap.org/way/124759292 https://www.cyclosm.org/#map=15/45.0035/3.8913/cyclosm
May because of I guess (we don't render underground railway)

railway=abandoned
tunnel=yes

@DaveF63
Copy link
Author

DaveF63 commented Nov 2, 2019

So a test for the value of the railway tag needs to be included to ignore abandoned/disused/razed?

@Florimondable
Copy link
Member

highway tag should prevail over railway one I'd say.

@Phyks Phyks added the bug Something isn't working label Nov 4, 2019
@Phyks Phyks added this to the v0.4 milestone Nov 4, 2019
@Phyks
Copy link
Member

Phyks commented Nov 4, 2019

This is indeed a bug. We hide any railway with tunnel=yes (https://github.com/cyclosm/cyclosm-cartocss-style/blob/master/project.mml#L529). It should probably read

railway NOT IN ('light_rail', 'subway', 'narrow_gauge', 'rail', 'tram')

instead of the railway IS NULL test.

@Florimondable
Copy link
Member

I'm not sure, I think we can have the real case of a tunnel with a road shared with a train (with rail on it), like :

highway=tertiary
railway=tram

@Florimondable
Copy link
Member

few examples in île de France:
https://www.openstreetmap.org/way/190293163
https://www.openstreetmap.org/way/310782687
https://www.openstreetmap.org/way/41080494

I think we should render as long as there is the highway tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants