Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No rendering for aerialway=* #256

Closed
pgavrilov opened this issue Nov 26, 2019 · 14 comments
Closed

No rendering for aerialway=* #256

pgavrilov opened this issue Nov 26, 2019 · 14 comments
Assignees
Labels
high zooms Issues affecting high zoom levels new feature Render a new feature
Milestone

Comments

@pgavrilov
Copy link

No rendering for aerialway=cable_car and aerialway=chair_lift

https://www.openstreetmap.org/#map=15/47.7054/12.8747
https://www.cyclosm.org/#map=15/47.7052/12.8744/cyclosm
aerialway OSM
aerialway Cyclosm

@Phyks Phyks added high zooms Issues affecting high zoom levels new feature Render a new feature labels Nov 27, 2019
@Phyks
Copy link
Member

Phyks commented Nov 27, 2019

aerialway are usually not bike-friendly (chair lift at least). Should we render all of them (considering they are easy to spot in the landscape and to orient with) or only the bike-friendly ones (probably just cable_car and with bicycle hint)?

@Florimondable
Copy link
Member

Render all of them, use aerialway:bicycle | yes/summer/no to render in blue or not, I’d say.

https://wiki.openstreetmap.org/wiki/Key:aerialway

@quasart
Copy link
Contributor

quasart commented Nov 27, 2019

Just in case you didn't notice, wiki says about aerialway:bicycle :

By default, cablecar, gondola, and mixed_lift imply yes, and chairlifts, t-bars imply no

@pgavrilov
Copy link
Author

pgavrilov commented Nov 28, 2019

These objects provide good guidance, and they can help to understand map. So, you render river even if it is not bike-friendly.

@Phyks Phyks added this to the v0.4 milestone Dec 1, 2019
@Phyks Phyks self-assigned this Dec 1, 2019
@Phyks Phyks closed this as completed in dcb6b63 Dec 1, 2019
@Phyks
Copy link
Member

Phyks commented Dec 1, 2019

Done. I did not consider the aerialway:bicycle=summer edge case so far (it is a synonym for yes currently). Rendering it better falls within the scope of #65.

2019-12-01-183318

https://www.cyclosm.org/#16/45.5133/2.8442

@Florimondable
Copy link
Member

Not link to #65, aerialway:bicycle is just an access restriction tag.
I would not render cable_car in blue if access to bicycle is not set.

@Phyks
Copy link
Member

Phyks commented Dec 1, 2019

aerialway:bicycle=summer is a temporal restriction, no? So I somehow link it to the question of how to render temporal restriction / intermittent features.

@pgavrilov
Copy link
Author

Done. I did not consider the aerialway:bicycle=summer edge case so far (it is a synonym for yes currently). Rendering it better falls within the scope of #65.

I think, aerialways must be shown at least at zoom 14, may be 13.
Note: usually it is some kilometers long object.

@Florimondable
Copy link
Member

Florimondable commented Dec 1, 2019

aerialway:bicycle=summer is a temporal restriction, no? So I somehow link it to the question of how to render temporal restriction / intermittent features.

Yes, you're right

I think, aerialways must be shown at least at zoom 14, may be 13.
Note: usually it is some kilometers long object.

They are now available from z14, but I think we should render from 13 at least
https://www.cyclosm.org/#map=14/-16.5121/-68.1306/cyclosm

@Phyks
Copy link
Member

Phyks commented Dec 1, 2019

They are now available from z14, but I think we should render from 13 at least

It is already the case, it should be rendered from Z12, just as on osm.org. See https://github.com/cyclosm/cyclosm-cartocss-style/blob/master/project.mml#L766-L786 and https://github.com/cyclosm/cyclosm-cartocss-style/blob/master/aerialways.mss#L5.

@Florimondable
Copy link
Member

There is misspell here

WHEN aerialway IN ('cablecar', 'gondola', 'mixed_lift') AND (tags->'aeriwaly:bicycle' IS NULL OR tags->'aerialway:bicycle' != 'no') THEN 'yes'

-> aeriwaly

@Florimondable
Copy link
Member

And bicycle=yes is missing for chair_lift and others

@Phyks
Copy link
Member

Phyks commented Dec 2, 2019

There is misspell here

Indeed, fixed.

And bicycle=yes is missing for chair_lift and others

bicycle tag seems ultra minoritary from taginfo. I think correct tagging is using aerialway:bicycle, isn't it?

@Florimondable
Copy link
Member

And bicycle=yes is missing for chair_lift and others

bicycle tag seems ultra minoritary from taginfo. I think correct tagging is using aerialway:bicycle, isn't it?

It's what I meant of course.
(weird tagging scheme btw)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high zooms Issues affecting high zoom levels new feature Render a new feature
Projects
None yet
Development

No branches or pull requests

4 participants