Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render bicycle shops when multiple values are used for a shop tag #573

Closed
VladimirMorozov opened this issue May 24, 2021 · 4 comments
Closed

Comments

@VladimirMorozov
Copy link

Values for shops like this
shop=bicycle;car_parts
are not rendered.

https://www.openstreetmap.org/node/8757476652#map=20/59.44422/24.86005&layers=Y
This shop sells both car and bicycle parts and also offers bicycle repairs.
I think it should be rendered the same as a shop=bicycle.

@Phyks
Copy link
Member

Phyks commented May 25, 2021

Hi,

Thanks for the report. Sadly, ; for separating values of a given OSM tag is not standardized across OSM and very few tools can efficiently using it. As such, supporting it in CyclOSM would require either adding support for all bicycle;* values, or using a regex-like SQL query to fetch the shop=*bicycle* tags. Both are not something that can be envisioned at the scale CyclOSM is operating.

A better workaround is to add service:bicycle=* tags that will be rendered in CyclOSM: https://github.com/cyclosm/cyclosm-cartocss-style/blob/140c8c1/project.mml#L1804-L1808.

Best

@Phyks Phyks closed this as completed May 25, 2021
@VladimirMorozov
Copy link
Author

@Phyks it does have a service:bicycle:repair=yes tag.

@quasart
Copy link
Contributor

quasart commented May 26, 2021

It looks like housenumber is rendered with higher priority than bicycle repair amenity

@Phyks
Copy link
Member

Phyks commented May 26, 2021

We were missing service:bicycle:* nodes which would not have been rendered otherwise (no other tag rendered). This is fixed in c84bfea.

Thanks for pointing out @VladimirMorozov !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants