Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require matching client-server cylc versions. #1522

Closed
hjoliver opened this issue Jun 28, 2015 · 9 comments
Closed

Require matching client-server cylc versions. #1522

hjoliver opened this issue Jun 28, 2015 · 9 comments

Comments

@hjoliver
Copy link
Member

From an email exchange between @matthewrmshin and myself:

I am thinking that perhaps we can have a setting in place to force matching versions by default. We can have the setting switched off for development or debugging purpose. CLI clients should fail if versions don't match (or re-launch, "remrun" style?) GUI can display a dialog with a small delay then re-launch with the correct version?

@hjoliver hjoliver added this to the later milestone Jun 28, 2015
@hjoliver
Copy link
Member Author

(note we had an unsophisticated version of this back at cylc-4, which I called "pseudo backward compatibility": a required version had to be specified in a comment at the top of the suite definition, and commands would re-invoke themselves at that version).

@matthewrmshin
Copy link
Contributor

It doesn't sound too unsophisticated. Perl, package managers, etc all have something similar (although they tend to fail if they cannot find the matching versions.)

@hjoliver
Copy link
Member Author

I suppose this should be achieved via info stored in the suite run directory, so that by default the cylc version remains the same even after a shutdown.

@matthewrmshin - rose suite-run already does this for cylc via log/rose-suite-run.conf, but there's nothing to stop users from running cylc restart on a Rose-cylc suite, in which case the cylc version recorded by rose suite-run can differ from the actual version in use, which can screw up subsequent user of rose suite-run. I guess this will be resolved when rose suite-run functionality is migrated to cylc.

@matthewrmshin
Copy link
Contributor

I guess this will be resolved when rose suite-run functionality is migrated to cylc.

Yes, this is one of the functionalities to migrate.

@benfitzpatrick
Copy link
Contributor

Can we have an API version string for the comms layer (see #1872).

@benfitzpatrick benfitzpatrick changed the title Force matching client-server cylc versions. Require matching client-server cylc versions. Jun 13, 2016
@hjoliver
Copy link
Member Author

hjoliver commented Jun 19, 2016

[meeting] we agreed:

@oliver-sanders
Copy link
Member

#2123 would supersede this.

@matthewrmshin
Copy link
Contributor

Suggest a review of this issue before releasing cylc-8.0.0.

@matthewrmshin matthewrmshin modified the milestones: later, cylc-8.0.0 Aug 28, 2019
@oliver-sanders
Copy link
Member

Closing this here as it's no longer a Cylc Flow issue and the version forcing approach is not compatible with the new framework. We will instead attempt to either detect compatibility or support a version range.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants