Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit CYLC_DIR use #3080

Closed
kinow opened this issue Apr 6, 2019 · 3 comments · Fixed by #3162
Closed

Revisit CYLC_DIR use #3080

kinow opened this issue Apr 6, 2019 · 3 comments · Fixed by #3162
Assignees
Labels
bug Something is wrong :(
Milestone

Comments

@kinow
Copy link
Member

kinow commented Apr 6, 2019

We had a few hiccups with CYLC_DIR when adding setup.py to the project (#2989). That's due to how setuptools installs python projects, where files may use multiple folders, so there's no more concept of CYLC_DIR after this.

Using Anaconda and virtual environments, it's not necessary to have CYLC_DIR any longer. A few fixes were done for #2989, but there might be still some commands using it (and perhaps working or not).

@kinow kinow added the bug Something is wrong :( label Apr 6, 2019
@kinow kinow added this to the cylc-8.0a1 milestone Apr 6, 2019
@hjoliver
Copy link
Member

hjoliver commented Apr 6, 2019

@kinow - I guess the point of this issue is just to check for any remaining use of CYLC_DIR and remove it, after #2989 is merged?

@kinow
Copy link
Member Author

kinow commented Apr 7, 2019

That's right @hjoliver. A just-in-case issue

@hjoliver hjoliver self-assigned this May 10, 2019
@hjoliver
Copy link
Member

I'm working on getting rid of CYLC_DIR, will post a PR soon. Some details:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong :(
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants