Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow proper escaping in xtrigger format statements #3256

Closed
trwhitcomb opened this issue Jul 29, 2019 · 1 comment · Fixed by #3258
Closed

Allow proper escaping in xtrigger format statements #3256

trwhitcomb opened this issue Jul 29, 2019 · 1 comment · Fixed by #3258
Assignees
Labels
bug Something is wrong :(
Milestone

Comments

@trwhitcomb
Copy link
Collaborator

I had a format string that I wanted to pass through the xtrigger formatting, but the regular expression used to match format strings and check their validity did not honor the Python escape sequence, i.e.
"%%(asdf)s" after running through string format is "%(asdf)s", but the current xtrigger format check in the suite validation complains that "asdf" isn't one of the approved variables for string substitution.

Use case here is to allow for parameterized filenames in the xtrigger, but I can't directly use cycle points as the files have 10-digit YYYYMMDDHH in the name so I resorted to passing in a format-string filename and a date-time-group format.

@trwhitcomb trwhitcomb added the bug Something is wrong :( label Jul 29, 2019
@hjoliver hjoliver self-assigned this Jul 30, 2019
@hjoliver hjoliver added this to the next-release milestone Jul 30, 2019
@hjoliver
Copy link
Member

hjoliver commented Jul 30, 2019

Bug reproduced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong :(
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants