Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests/jobscript/05-global-config.t for use with platforms #3481

Closed
wxtim opened this issue Jan 16, 2020 · 2 comments
Closed

Fix tests/jobscript/05-global-config.t for use with platforms #3481

wxtim opened this issue Jan 16, 2020 · 2 comments
Labels
bug Something is wrong :(
Milestone

Comments

@wxtim
Copy link
Member

wxtim commented Jan 16, 2020

Earlier work on platforms has broken this test:

We are not intending to have this globalconfig work in Cylc 8. The best this test should give is a helpful warning, but that warning should already have been given elsewhere. More likely we need to re-write this in a platformsy way.

@wxtim wxtim added the bug Something is wrong :( label Jan 16, 2020
@wxtim wxtim added this to the cylc-8.0a2 milestone Jan 16, 2020
@hjoliver hjoliver modified the milestones: cylc-8.0a2, cylc-8.0a3 Apr 30, 2020
@oliver-sanders
Copy link
Member

@datamel you get to close this one the easy way!

@wxtim
Copy link
Member Author

wxtim commented Sep 17, 2020

This issue can be closed at the test in question has been replaced by tests/unit/test_job_file.py

@wxtim wxtim closed this as completed Sep 17, 2020
@hjoliver hjoliver modified the milestones: cylc-8.0a3, cylc-8.0b0 Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong :(
Projects
None yet
Development

No branches or pull requests

3 participants