Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cycling sequence check methods #3934

Open
hjoliver opened this issue Nov 11, 2020 · 0 comments
Open

cycling sequence check methods #3934

hjoliver opened this issue Nov 11, 2020 · 0 comments
Milestone
8.x

Comments

@hjoliver
Copy link
Member

The is_on_sequence and is_valid methods have caused some confusion recently (twice). One doesn't check sequence bounds (for integer cycling only?).

  • they should behave consistently across datetime and integer cycling
  • do we really need a method that checks a point is "on sequence" without checking sequence bounds?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.x
Development

No branches or pull requests
1 participant
@hjoliver