Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep-alive timeout for restarted completed workflows #5078

Closed
hjoliver opened this issue Aug 16, 2022 · 3 comments · Fixed by #5231
Closed

keep-alive timeout for restarted completed workflows #5078

hjoliver opened this issue Aug 16, 2022 · 3 comments · Fixed by #5231
Assignees
Labels
Milestone

Comments

@hjoliver
Copy link
Member

hjoliver commented Aug 16, 2022

https://cylc.discourse.group/t/adding-new-task-to-succeeded-workflow-explicit-insertion/520/3

If a workflow completes and shuts down, but you want to start the scheduler again and trigger some new action (whether past tasks or new ones added to the graph since the workflow completed), currently you have to:

  • cylc play --pause so the scheduler doesn't just shut down again immediately (workflow finished)
  • then cylc play (unpause) after triggering tasks, so that the triggered tasks can submit

The above steps are perhaps not very intuitive (for instance, it's not obvious that "pause" should stop the scheduler from shutting down).

QUESTION: If a completed workflow is restarted, should it stay alive for some timeout period to allow user intervention.

(Pegging against 8.1 as would be easy to implement - just a variant of the current stall timer - and we have evidence that it affects users incrementally developing new workflows).

@hjoliver hjoliver added small question Flag this as a question for the next Cylc project meeting. labels Aug 16, 2022
@hjoliver hjoliver added this to the cylc-8.1.0 milestone Aug 16, 2022
@oliver-sanders
Copy link
Member

oliver-sanders commented Oct 5, 2022

Suggest:

  • A short timeout (e.g. PT2M).
  • A warning message (saying, workflow completed, trigger a task to (re)start a flow).

The warning message should be flagged in the UI with #4148.

@hjoliver
Copy link
Member Author

I'll take that as agreement; removing the question label.

@hjoliver hjoliver removed the question Flag this as a question for the next Cylc project meeting. label Oct 10, 2022
@hjoliver hjoliver self-assigned this Nov 16, 2022
@hjoliver
Copy link
Member Author

(I have this done, will post a PR tomorrow)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants