Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increment_graph_window: don't revisit nodes #5485

Closed
oliver-sanders opened this issue Apr 24, 2023 · 1 comment
Closed

increment_graph_window: don't revisit nodes #5485

oliver-sanders opened this issue Apr 24, 2023 · 1 comment
Assignees
Labels
efficiency For notable efficiency improvements
Milestone

Comments

@oliver-sanders
Copy link
Member

Avoid re-visiting nodes in the increment_graph_window algorithm.

This will help to reduce the number of recursive calls and will allow us to efficiently include "cousins" in the n>1 window.

Note: Cousins
For the graph a => <b> => c, if b1 is active, then b2 is a cousin which should be included in the n=2 window.

See this comment and the larger issue for discussion:

Not revisiting nodes

we can do this by storing graph relations in an easily referenced way (if we don't already)
adopting graph sections visited, and skipping walks to head of adopted section (if required)

--- #5435 (comment)

@MetRonnie
Copy link
Member

Closed by #5600

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
efficiency For notable efficiency improvements
Projects
None yet
Development

No branches or pull requests

3 participants