Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscription being reloaded unnecessarily #778

Closed
kinow opened this issue Sep 20, 2021 · 0 comments · Fixed by #779
Closed

Subscription being reloaded unnecessarily #778

kinow opened this issue Sep 20, 2021 · 0 comments · Fixed by #779
Assignees
Labels
bug Something isn't working
Milestone

Comments

@kinow
Copy link
Member

kinow commented Sep 20, 2021

Describe the bug

Found this while testing a PR with @hjoliver #749 (comment)

Copied the initialQuery and finalQuery, and realized it's a bug caused by #726

The diff shows that some values were incorrectly merged.

Release version(s) and/or repository branch(es) affected?

master

Steps to reproduce the bug

  1. Add a Tree view
  2. Add a second Tree view
  3. Either observe in Network tab or see if the components are cleared, leaving a blank view, then reloaded

Expected behavior

Since both views use the same query, nothing must change in the UI, except for a new view added.

Screenshots

Additional context

kinow@ranma:/tmp$ diff initial final
2c2
<   deltas(workflows: [$workflowId], stripNull: true) {
---
>   deltas(workflows: [$workflowId, $workflowId], stripNull: true) {
24c24
<   cyclePoints: familyProxies(ids: ["root"], ghosts: true) {
---
>   cyclePoints: familyProxies(ids: ["root", "root"], ghosts: true) {
27c27
<   familyProxies(exids: ["root"], sort: {keys: ["name"]}, ghosts: true) {
---
>   familyProxies(exids: ["root", "root"], sort: {keys: ["name"]}, ghosts: true) {
45c45
<   familyProxies(exids: ["root"], ghosts: true) {
---
>   familyProxies(exids: ["root", "root"], ghosts: true) {
65c65
<     states: ["failed", "preparing", "submit-failed", "submitted", "running"]
---
>     states: ["failed", "preparing", "submit-failed", "submitted", "running", "failed", "preparing", "submit-failed", "submitted", "running"]

Pull requests welcome!
This is an Open Source project - please consider contributing a bug fix
yourself (please read CONTRIBUTING.md before starting any work though).

@kinow kinow added the bug Something isn't working label Sep 20, 2021
@kinow kinow self-assigned this Sep 20, 2021
@kinow kinow added this to the 0.6.0 milestone Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant