Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configuration path root #291

Closed
oliver-sanders opened this issue Nov 29, 2021 · 3 comments · Fixed by #301
Closed

configuration path root #291

oliver-sanders opened this issue Nov 29, 2021 · 3 comments · Fixed by #301
Assignees
Labels

Comments

@oliver-sanders
Copy link
Member

Follow on from #189

This project is called cylc-uiserver, however, it configures both the hub and the UIS.

At present the config path is ~/.cylc/hub, should this be changed to ~/.cylc/uiserver to match ~/.cylc/flow?

@oliver-sanders oliver-sanders added question Flag this as a question for the next Cylc project meeting. small labels Nov 29, 2021
@oliver-sanders oliver-sanders added this to the cylc-uiserver 1.0.0 milestone Nov 29, 2021
@oliver-sanders oliver-sanders removed the question Flag this as a question for the next Cylc project meeting. label Nov 30, 2021
@oliver-sanders
Copy link
Member Author

oliver-sanders commented Nov 30, 2021

Agreed, rename to uiserver.

@hjoliver
Copy link
Member

hjoliver commented Dec 6, 2021

Somewhat relatedly, the server config file can be called:

  • jupyter_config.py
  • jupyter_cylc_config.py
  • (jupyterhub_config.py for hub-launched only)

Should we document/recommend use of jupyter_cylc_config.py for maximum clarity?

Even though cylc is in the path name for installed site and user configs, it would makes sense for command line use of temporary config files: cylc gui --config=jupyter_cylc_config.py.

@oliver-sanders
Copy link
Member Author

oliver-sanders commented Dec 7, 2021

Should we document/recommend use of jupyter_cylc_config.py for maximum clarity?

I think this file targets the Cylc extension so would not be loaded by other Jupyter components. These targeted files should be used to configure the one specific component (server, extension, hub, lab, etc) whereas we use it to configure multiple (e.g. we might set the spawner command used by the hub, set the logging config for the server and set the scan interval for the Cylc extension).

I think using the generic jupyter_config.py as documented is the clearest way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants