Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logging: rollover on restart #352

Closed
oliver-sanders opened this issue May 19, 2022 · 1 comment · Fixed by #376
Closed

logging: rollover on restart #352

oliver-sanders opened this issue May 19, 2022 · 1 comment · Fixed by #376
Assignees
@datamel
Labels
small
Milestone
1.2.0

Comments

@oliver-sanders
Copy link
Member

Follow on from #349

The logging.handlers.RotatingFileHandler does not support automatically rolling over on restart which would be a nice feature.

To add this, subclass RotatingFileHandler and add the logic to call rollover at the end of the __init__ method, then update the logging_config to use this handler instead.

Pull requests welcome!
@oliver-sanders oliver-sanders added this to the 1.1.0 milestone May 19, 2022
@oliver-sanders oliver-sanders added the question Flag this as a question for the next Cylc project meeting. label May 19, 2022
@oliver-sanders oliver-sanders modified the milestones: 1.1.0, 1.2.0 May 19, 2022
@hjoliver hjoliver modified the milestones: 1.3.0, 1.4.0 Jul 26, 2022
@oliver-sanders oliver-sanders modified the milestones: 1.4.0, 1.2.0 Jul 28, 2022
@datamel datamel self-assigned this Aug 8, 2022
@datamel
Copy link
Contributor

datamel commented Aug 9, 2022

Discussed at team meeting in UK. This no longer needs question label as decided sensible to implement.

@datamel datamel removed the question Flag this as a question for the next Cylc project meeting. label Aug 9, 2022
This was referenced Aug 10, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@datamel datamel

Labels
small
Projects
None yet
Milestone
1.2.0
Development

Successfully merging a pull request may close this issue.

Add logging_util and rotating log archive for uiserver logs datamel/cylc-uiserver
3 participants
@hjoliver @oliver-sanders @datamel