Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cat-log: cancel active subscriptions if clean is issued #417

Open
oliver-sanders opened this issue Feb 1, 2023 · 1 comment
Open

cat-log: cancel active subscriptions if clean is issued #417

oliver-sanders opened this issue Feb 1, 2023 · 1 comment
Milestone
pending

Comments

@oliver-sanders
Copy link
Member

If a cylc clean command is issued we should stop and cat-log subscriptions for that workflow.

This is because network file systems may keep a temporary file open for the tail commands resulting from cat-log subscriptions which can block cylc clean from completing.

In other words, if you open a log file in the GUI, then try to clean the workflow, the clean command will fail.

Pull requests welcome!
@oliver-sanders oliver-sanders added this to the pending milestone Feb 1, 2023
@datamel datamel mentioned this issue Feb 2, 2023
Closed
@oliver-sanders
Copy link
Member Author

This requires review after: cylc/cylc-flow#5359

Does the cat-log die when the tail dies, or is additional cleanup required?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
pending
Development

No branches or pull requests
1 participant
@oliver-sanders