Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure logging for the Cylc UI Server app #67

Closed
kinow opened this issue Aug 19, 2019 · 0 comments · Fixed by #73
Closed

Configure logging for the Cylc UI Server app #67

kinow opened this issue Aug 19, 2019 · 0 comments · Fixed by #73
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Milestone

Comments

@kinow
Copy link
Member

kinow commented Aug 19, 2019

I added some logging in main.py some time ago, while working on the initial prototype. But there was nothing important in those logging messages.

While looking at #65 , I wondered where exceptions were logged. Looks like the GraphQL client code is not logging exceptions (neither is the rest of the application to be honest).

We need to look at how JupyterHub and its spawned applications handle logging, and use it properly in Cylc UI Server. A quick look at the JupyterHub code, looks like they use some code from Tornado logging.

But I am not sure if that's the only way they are handling logging.

Cheers
Bruno

@kinow kinow added enhancement good first issue Good for newcomers help wanted Extra attention is needed labels Aug 19, 2019
@kinow kinow changed the title Configure logging for the app Configure logging for the Cylc UI Server app Aug 19, 2019
@kinow kinow self-assigned this Sep 9, 2019
@kinow kinow mentioned this issue Sep 9, 2019
@kinow kinow added this to the 0.1 milestone Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant