Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pass opts rather than dots #63

Closed
moodymudskipper opened this issue Oct 14, 2022 · 1 comment
Closed

pass opts rather than dots #63

moodymudskipper opened this issue Oct 14, 2022 · 1 comment
Labels
internals
Milestone
1.0.0

Comments

@moodymudskipper
Copy link
Collaborator

From #56

I now think the ... should just be for the user facing interface. We might just pass around an opts object.

As an early step we resolve the the "constructive_options" object, the named args, and the template into an opts object and we forward it. dots don't need to be used. It's more efficient too, we don't fetch_opts() several times.

This is internal/not breaking, so not crucial for 1st CRAN release
@moodymudskipper moodymudskipper added this to the 0.2 milestone Oct 14, 2022
@moodymudskipper moodymudskipper modified the milestones: 0.2, 1.0.0 Apr 30, 2024
@moodymudskipper
Copy link
Collaborator Author

was done in #412

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
internals
Milestone
1.0.0
Development

No branches or pull requests
1 participant
@moodymudskipper