-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Naming pattern not used in dm_from_con()
when keys are learned successfully
#2213
Comments
owenjonesuob
added a commit
to owenjonesuob/dm
that referenced
this issue
May 3, 2024
owenjonesuob
added a commit
to owenjonesuob/dm
that referenced
this issue
May 3, 2024
krlmlr
pushed a commit
to owenjonesuob/dm
that referenced
this issue
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A new
.names
parameter was added todm_from_con()
in v1.0.6 (#1790) - but it's currently ignored whenlearn_keys = TRUE
and the subsequent key-querying is successful.That's because
dm_from_con()
returns early if key-querying, viadm_learn_from_db()
, succeeds.Helpfully,
dm_learn_from_db()
already accepts anames_pattern
argument, which is used to format the table names with {glue} in the same way as elsewhere - but we don't pass.names
through to it indm_from_con()
:dm/R/dm_from_con.R
Line 71 in e52ba91
For what it's worth, if key-querying fails, then later in
dm_from_con()
we do pass.names
through toget_src_tbl_names()
:dm/R/dm_from_con.R
Line 107 in e52ba91
The text was updated successfully, but these errors were encountered: