Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Success of graceful shutdown changes, commit 92dab3802843134a0a1b1e25d23f700292969bb0 questionable #717

Closed
d-hoke opened this issue May 11, 2018 · 1 comment
Labels

Comments

@d-hoke
Copy link

d-hoke commented May 11, 2018

Regarding commit at 92dab38

From comment previously added to the commit:
"If I understand docs correctly, gracefulShutdown() will not be called if either of those .Reboot() calls is successful.
from http://man7.org/linux/man-pages/man2/reboot.2.html
"For the values of cmd that stop or restart the system, a successful
call to reboot() does not return."

Unless you only wanted to call gracefulShutdown() if the .Reboot() calls failed, then...
Consider modifying gracefulShutdown() to take a parameter about whether to exit or not (it currently appears to exit at its end), move the gracefulShutdown() calls before reboot, and use the parameter to
not exit when called from before the .Reboot()s..."

(Was uncertain if the comment had been seen. If it had, sorry for the noise here.)

@cyoung
Copy link
Owner

cyoung commented May 11, 2018

92dab38

Will fix.

@cyoung cyoung added the bug label Oct 10, 2018
@cyoung cyoung closed this as completed in 8f4a52d Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants