You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
From comment previously added to the commit:
"If I understand docs correctly, gracefulShutdown() will not be called if either of those .Reboot() calls is successful.
from http://man7.org/linux/man-pages/man2/reboot.2.html
"For the values of cmd that stop or restart the system, a successful
call to reboot() does not return."
Unless you only wanted to call gracefulShutdown() if the .Reboot() calls failed, then...
Consider modifying gracefulShutdown() to take a parameter about whether to exit or not (it currently appears to exit at its end), move the gracefulShutdown() calls before reboot, and use the parameter to
not exit when called from before the .Reboot()s..."
(Was uncertain if the comment had been seen. If it had, sorry for the noise here.)
The text was updated successfully, but these errors were encountered:
Regarding commit at 92dab38
From comment previously added to the commit:
"If I understand docs correctly, gracefulShutdown() will not be called if either of those .Reboot() calls is successful.
from http://man7.org/linux/man-pages/man2/reboot.2.html
"For the values of cmd that stop or restart the system, a successful
call to reboot() does not return."
Unless you only wanted to call gracefulShutdown() if the .Reboot() calls failed, then...
Consider modifying gracefulShutdown() to take a parameter about whether to exit or not (it currently appears to exit at its end), move the gracefulShutdown() calls before reboot, and use the parameter to
not exit when called from before the .Reboot()s..."
(Was uncertain if the comment had been seen. If it had, sorry for the noise here.)
The text was updated successfully, but these errors were encountered: