🐛 [Bug] Cypht not compatible with PHP 8.4

[s22-tech]

Cypht appears to not be compatible with PHP 8.4. Running the bash script from the install page generated a log of over 7,000 lines, with most entries like the following:

Deprecation Notice: Constant E_STRICT is deprecated in phar:///opt/cpanel/composer/bin/composer/src/Composer/Util/Silencer.php:36
Deprecation Notice: Composer\CaBundle\CaBundle::getSystemCaRootBundlePath(): Implicitly marking parameter $logger as nullable is deprecated, the explicit nullable type must be used instead in phar:///opt/cpanel/composer/bin/composer/vendor/composer/ca-bundle/src/CaBundle.php:67

So I dropped the PHP version on the server to 8.13 and it installed without those notices. The only thing that looked a little strange were the following lines:

4 additional suggestions by transitive dependencies can be shown with --all
cp: cannot stat 'cypht-master/.env.example.ini': No such file or directory
chmod: cannot access 'cypht-master/vendor/thomaspark/bootswatch/docs/3/bower_components/html5shiv/MIT': No such file or directory
chmod: cannot access 'and': No such file or directory
chmod: cannot access 'GPL2': No such file or directory
chmod: cannot access 'licenses.md': No such file or directory
chmod: cannot access 'cypht-master/vendor/garethp/php-ews/Resources/recordings/garethp/ews/Test/APITest.testListItemChanges': No such file or directory
chmod: cannot access 'with': No such file or directory
chmod: cannot access 'data': No such file or directory
chmod: cannot access 'set': No such file or directory
chmod: cannot access '#0.json': No such file or directory
chmod: cannot access 'cypht-master/vendor/garethp/php-ews/Resources/recordings/garethp/ews/Test/APITest.testGetFolderByDisplayName': No such file or directory
chmod: cannot access 'with': No such file or directory
chmod: cannot access 'data': No such file or directory
chmod: cannot access 'set': No such file or directory
chmod: cannot access '#0.json': No such file or directory

I've attached the install log from the 8.4 attempt, in case that helps.

Cypht istall log.txt

[marclaporte]

@IrAlfred @Baraka24 @Bienvenumoringa @amaninyumu1 @christer77

Who can take this on?

[christer77]

• https://lindevs.com/e_strict-constant-is-deprecated-in-php-8-4
• https://xenforo.com/community/threads/php-8-4-php-deprecated-constant-e_strict-is-deprecated-in-web-public_html-src-xf-template-templater-php.226000/

[marclaporte]

Cypht appears to not be compatible with PHP 8.4.

FYI, deprecated means it still works but there will be issues in the future. The E_STRICT constant will be removed in PHP 9.0.

If an application tries to support a wide range of PHP versions, it can become a little tricky.

Cypht 2.x requires PHP 8.1+ as per our policy: https://github.com/cypht-org/cypht/wiki/Lifecycle

"PHP core and core extensions since PHP 8.0 and later do not emit E_STRICT notices at all. It is safe to assume that any PHP applications that run on PHP 8.0 and later will never encounter E_STRICT notices, and error reporting and handling can be safely updated to ignore E_STRICT notices." Source: https://php.watch/versions/8.4/E_STRICT-deprecated

[marclaporte]

wait

One of the warnings is:

Deprecation Notice: Constant E_STRICT is deprecated in phar:///opt/cpanel/composer/bin/composer/src/Composer/Util/Silencer.php:36

This looks like it's supplied by cPanel.

In Tiki Manager, we did this so Tiki Manager would use its own Composer instead of one perhaps supplied by the server: https://gitlab.com/tikiwiki/tiki-manager/-/merge_requests/237

This also reminds me of #1154