Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A "remark" field to remember why you added a profile #882

Closed
Tracked by #903
w-b-k opened this issue Feb 5, 2024 · 14 comments
Closed
Tracked by #903

A "remark" field to remember why you added a profile #882

w-b-k opened this issue Feb 5, 2024 · 14 comments
Assignees

Comments

@w-b-k
Copy link

w-b-k commented Feb 5, 2024

🗣 Suggestion

I create a mail alias and a corresponding identity/profile per organization/entity/contact that I deal with, to isolate data leaks and prevent merging of profiles in different providers' back-ends.
The aliases are not very self-explanatory, so I keep notes which alias goes with which entity.

For me it would be helpful to have a "remarks" field in addition to the "signature" field when managing profiles. Is it too much a niche application of aliases/profiles to have any merit outside of my application, or would it be something useful for a wider audience?

Thank you for your consideration!

@marclaporte
Copy link
Member

@w-b-k I Iike it. Let's do it.

@marclaporte
Copy link
Member

@IrAlfred Please show us your skills :-)

@marclaporte
Copy link
Member

@w-b-k: looking at this more:

There are two text fields:

  • Display Name
  • Signature

What would be negative about using the Display Name?

@IrAlfred
Copy link
Member

IrAlfred commented Feb 6, 2024

@IrAlfred Please show us your skills :-)

Not sure to understand well what this is about, please I need more details

@w-b-k
Copy link
Author

w-b-k commented Feb 6, 2024

Hi, thanks for your prompt response ! :-)

What would be negative about using the Display Name?

Is the display name not the field that is sent as "My Name" to the recipient of the email?

I would write something like "added this alias for exchange with the piano teacher; starting 20240103". If "Display name" is not sent as "My Name" with the email, is another field used to supply the recipient with my name?

@marclaporte
Copy link
Member

@w-b-k Good point. Please test, and if Display Name is used as you said, we'll add one more field.

@marclaporte
Copy link
Member

@w-b-k
Copy link
Author

w-b-k commented Feb 8, 2024

@w-b-k Good point. Please test, and if Display Name is used as you said, we'll add one more field.

Tested. The text entered in the "Display name" field is displayed in Cypht when sending a new message (below the field for typing the message, a combobox to select the from-identity).

In the receiving mail client, the text is displayed as the 'friendly name' in combination with the email address.

@IrAlfred Please show us your skills :-)

Not sure to understand well what this is about, please I need more details

I got there by cilcking Profiles under Settings:

image

When adding (or editing) a profile, the confusion was about the "Display name" field:

image

I'd like to have an option to write some remarks about why I added the particular profile:

image

(In a perfect world the field would be multi line, or a wider letter box :-P )

@IrAlfred
Copy link
Member

Okay, thanks

@marclaporte
Copy link
Member

@w-b-k Can you please test? #903

@w-b-k
Copy link
Author

w-b-k commented Feb 17, 2024

Hi Alfred & Marc,

Thank you, looks (and works, on first test) great!

A small non-functional remark on the changes in modules.php : in most places the rmk is added after sig, but in a cases it is added on a different position, for example on line 129 it follows 'type', instead of 'sig' (at line 121). Is that on purpose?

Edit: on second, more general test:

  • Setting/retrieving a remark with a profile works (new with this change)
  • Setting/retrieving a signature works (is not new)
  • A signature is not added to outgoing mail (is not as expected)

I'm not a heavy user of preconfigured signatures. I am not sure whether it used to work, or that the not-working is specific to my installation: I noticed the new files being quite different from the ones I had installed (1.4.1, via Yunohost; what is the current version?)

@IrAlfred
Copy link
Member

Thank you for your feedback. Regarding the non-functional remark concerning the position of rmk in the module.php file compared to its position in other places, this was not done on purpose but just that we didn't pay too much attention to it . I fix that for good harmony.

@marclaporte
Copy link
Member

I noticed the new files being quite different from the ones I had installed (1.4.1, via Yunohost; what is the current version?)

Cypht 1.4.1 is the current stable version. Because of major changes in master, the next release will be 2.0

@marclaporte
Copy link
Member

@w-b-k Is the latest code good to merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants